Skip to content

Add config checkbox to show/hide redirect URLs on Homepage#307

Closed
orel-mor wants to merge 5 commits into
azukaar:unstablefrom
orel-mor:unstable
Closed

Add config checkbox to show/hide redirect URLs on Homepage#307
orel-mor wants to merge 5 commits into
azukaar:unstablefrom
orel-mor:unstable

Conversation

@orel-mor

Copy link
Copy Markdown

This gives users more personalization for what is shown on the home page :)

@cla-bot

cla-bot Bot commented Aug 16, 2024

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

@azukaar

azukaar commented Aug 19, 2024

Copy link
Copy Markdown
Owner

Thanks for the contribution!
Upon reviewing there's an issue with the general idea: basically, I don't think a generic "show redirect" is enough for this. Instead, I think the check should be per-URL.
There is already a "Hide from dashboard" option in URL, but the URLs that are redirect are ignored.
I think the PR should make it so redirects URLs are not ignored, but "hide from dashboard" is true by default when creating a redirect
I am just not exactly sure how to implement this because when you reach the form to create a URL, the ttoe gas bit been selected yet

@cla-bot

cla-bot Bot commented Aug 20, 2024

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

@orel-mor

orel-mor commented Aug 20, 2024

Copy link
Copy Markdown
Author

Thanks for the contribution! Upon reviewing there's an issue with the general idea: basically, I don't think a generic "show redirect" is enough for this. Instead, I think the check should be per-URL. There is already a "Hide from dashboard" option in URL, but the URLs that are redirect are ignored. I think the PR should make it so redirects URLs are not ignored, but "hide from dashboard" is true by default when creating a redirect I am just not exactly sure how to implement this because when you reach the form to create a URL, the ttoe gas bit been selected yet

I get what you're saying, then by this logic, changing the URL mode automatically decides the base value for HideFromDashboard, so I've implemented a simple onChange method for when a user changes the URL mode.
Now HideFromDashboard is automatically selected / deselected depending on the mode (selected if mode is redirect), the user can change this afterwards.
Also removed the auto-skip URL on homepage.

What do you say?

@azukaar

azukaar commented Aug 21, 2024

Copy link
Copy Markdown
Owner

Yes that looks better thanks! Could you remove the condition with the skip altogether? I dont think it will be required anymore since the value is always false
then it should be ready to merge

@cla-bot

cla-bot Bot commented Aug 21, 2024

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

@orel-mor

Copy link
Copy Markdown
Author

Yes that looks better thanks! Could you remove the condition with the skip altogether? I dont think it will be required anymore since the value is always false then it should be ready to merge

Done, is this what you meant?

@orel-mor orel-mor closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants